Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on 2.1 going non-beta? #10819

Closed
burtonator opened this issue May 13, 2019 · 9 comments
Closed

Clarification on 2.1 going non-beta? #10819

burtonator opened this issue May 13, 2019 · 9 comments
Labels

Comments

@burtonator
Copy link

I just need a clarification for when 2.1 is going non-beta. I also noticed that the demo version is running 2.2.x. I assume 2.2.x is alpha?

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented May 13, 2019

There's generally very little difference, as far as stability is concerned, between the stable/pre-release versions (since no code lands without e.g. all tests passing).
Firefox Nightly, for example, is always using what's essentially the latest master version of the PDF.js library. Hence the decision to use "stable" or "pre-release" versions is really up each implementer (and note that unless something is really broken, patches are generally not back-ported).

@timvandermeij
Copy link
Contributor

I do agree that we should make a new release again. @brendandahl If we follow the release process, does the existing pre-release automatically become stable (on GitHub and NPM) or do we need to do that ourselves somehow?

@Snuffleupagus
Copy link
Collaborator

I do agree that we should make a new release again.

In that case, how about making sure that #10794 is landed first?

@brendandahl
Copy link
Contributor

I do agree that we should make a new release again. @brendandahl If we follow the release process, does the existing pre-release automatically become stable (on GitHub and NPM) or do we need to do that ourselves somehow?

If everything is working correctly it should.

@Snuffleupagus
Copy link
Collaborator

I'd suggest trying to get PRs #10850 and #10851 (maybe #10879 as well) landed as soon as possible, and then just create a new release immediately afterwards (before considering landing any larger items).

@timvandermeij
Copy link
Contributor

Yes, I agree. Those three are mostly done, other PRs can wait. @brendandahl Could you fix up your two PRs?

@Camo30
Copy link

Camo30 commented Jul 5, 2019

I'm waiting for that too, but it seems it got stuck. Would be great to get a new release soon

@timvandermeij
Copy link
Contributor

I'm planning to make a new release next Wednesday.

@timvandermeij
Copy link
Contributor

Version 2.1 is now stable; refer to https://github.com/mozilla/pdf.js/releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants