Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a reduced, non-linked PDF file for the attachments API unit test #11095

Merged

Conversation

timvandermeij
Copy link
Contributor

The file is created using Poppler's pdfattach utility.

Fixes #11063.

@timvandermeij
Copy link
Contributor Author

/botio unittest

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great already, but I've added one small comment; thanks for fixing this!

test/unit/api_spec.js Outdated Show resolved Hide resolved
@mozilla mozilla deleted a comment from pdfjsbot Aug 25, 2019
@mozilla mozilla deleted a comment from pdfjsbot Aug 25, 2019
@mozilla mozilla deleted a comment from pdfjsbot Aug 25, 2019
@mozilla mozilla deleted a comment from pdfjsbot Aug 25, 2019
@timvandermeij
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e18a309bcbbecaa/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/b04dbb7ff67f36e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/e18a309bcbbecaa/output.txt

Total script time: 2.57 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/b04dbb7ff67f36e/output.txt

Total script time: 4.94 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit d64b498 into mozilla:master Aug 25, 2019
@timvandermeij timvandermeij deleted the api-attachments-unit-test branch August 25, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a non-linked PDF file for the 'gets attachments' unit-test
3 participants