Make the ObjectLoader use more efficient methods when determining if data needs to be loaded
#11284
Conversation
Snuffleupagus
force-pushed
the
ObjectLoader-allChunksLoaded
branch
from
d6211a9
to
14dc318
Compare
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/bdd5bfc4eac57de/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f2ae79d712d9720/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f2ae79d712d9720/output.txt Total script time: 18.71 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/bdd5bfc4eac57de/output.txt Total script time: 26.60 mins
|
Snuffleupagus
force-pushed
the
ObjectLoader-allChunksLoaded
branch
from
14dc318
to
92b2891
Compare
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/67269d611c752a1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3af6099ceb42557/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3af6099ceb42557/output.txt Total script time: 18.66 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/67269d611c752a1/output.txt Total script time: 26.60 mins
Image differences available at: http://54.215.176.217:8877/67269d611c752a1/reftest-analyzer.html#web=eq.log |
…f data needs to be loaded Currently, for data in `ChunkedStream` instances, the `getMissingChunks` method is used in a couple of places to determine if data is already available or if it needs to be loaded. When looking at how `ChunkedStream.getMissingChunks` is being used in the `ObjectLoader` you'll notice that we don't actually care about which *specific* chunks are missing, but rather only want essentially a yes/no answer to the "Is the data available?" question. Furthermore, when looking at how `ChunkedStream.getMissingChunks` itself is implemented you'll notice that it (somewhat expectedly) always iterates over *all* chunks. All in all, using `ChunkedStream.getMissingChunks` in the `ObjectLoader` seems like an unnecessary "heavy" and roundabout way to obtain a boolean value. However, it turns out there already exists a `ChunkedStream.allChunksLoaded` method, consisting of a *single* simple check, which seems like a perfect fit for the `ObjectLoader` use cases. In particular, once the *entire* PDF document has been loaded (which is usually fairly quick with streaming enabled), you'd really want the `ObjectLoader` to be as simple/quick as possible (similar to e.g. loading a local files) which this patch should help with. Note that I wouldn't expect this patch to have a huge effect on performance, but it will nonetheless save some CPU/memory resources when the `ObjectLoader` is used. (As usual this should help larger PDF documents, w.r.t. both file size and number of pages, the most.)
As we've seen in numerous other cases, avoiding unnecessary function calls is never a bad thing (even if the effect is probably tiny here).
Snuffleupagus
force-pushed
the
ObjectLoader-allChunksLoaded
branch
from
92b2891
to
2d35a49
Compare
|
Good improvement! |
Currently, for data in
ChunkedStreaminstances, thegetMissingChunksmethod is used in a couple of places to determine if data is already available or if it needs to be loaded.When looking at how
ChunkedStream.getMissingChunksis being used in theObjectLoaderyou'll notice that we don't actually care about which specific chunks are missing, but rather only want essentially a yes/no answer to the "Is the data available?" question.Furthermore, when looking at how
ChunkedStream.getMissingChunksitself is implemented you'll notice that it (somewhat expectedly) always iterates over all chunks.All in all, using
ChunkedStream.getMissingChunksin theObjectLoaderseems like an unnecessary "heavy" and roundabout way to obtain a boolean value. However, it turns out there already exists aChunkedStream.allChunksLoadedmethod, consisting of a single simple check, which seems like a perfect fit for theObjectLoaderuse cases.In particular, once the entire PDF document has been loaded (which is usually fairly quick with streaming enabled), you'd really want the
ObjectLoaderto be as simple/quick as possible (similar to e.g. loading a local files) which this patch should help with.Note that I wouldn't expect this patch to have a huge effect on performance, but it will nonetheless save some CPU/memory resources when the
ObjectLoaderis used. (As usual this should help larger PDF documents, w.r.t. both file size and number of pages, the most.)