Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the ObjectLoader use more efficient methods when determining if data needs to be loaded #11284

Merged
merged 2 commits into from Oct 30, 2019
Merged

Make the ObjectLoader use more efficient methods when determining if data needs to be loaded #11284

merged 2 commits into from Oct 30, 2019

Commits on Oct 29, 2019

  1. Make the ObjectLoader use more efficient methods when determining i… 

    …f data needs to be loaded

Currently, for data in `ChunkedStream` instances, the `getMissingChunks` method is used in a couple of places to determine if data is already available or if it needs to be loaded.

When looking at how `ChunkedStream.getMissingChunks` is being used in the `ObjectLoader` you'll notice that we don't actually care about which *specific* chunks are missing, but rather only want essentially a yes/no answer to the "Is the data available?" question.
Furthermore, when looking at how `ChunkedStream.getMissingChunks` itself is implemented you'll notice that it (somewhat expectedly) always iterates over *all* chunks.

All in all, using `ChunkedStream.getMissingChunks` in the `ObjectLoader` seems like an unnecessary "heavy" and roundabout way to obtain a boolean value. However, it turns out there already exists a `ChunkedStream.allChunksLoaded` method, consisting of a *single* simple check, which seems like a perfect fit for the `ObjectLoader` use cases.
In particular, once the *entire* PDF document has been loaded (which is usually fairly quick with streaming enabled), you'd really want the `ObjectLoader` to be as simple/quick as possible (similar to e.g. loading a local files) which this patch should help with.

Note that I wouldn't expect this patch to have a huge effect on performance, but it will nonetheless save some CPU/memory resources when the `ObjectLoader` is used. (As usual this should help larger PDF documents, w.r.t. both file size and number of pages, the most.)
    @Snuffleupagus
    Snuffleupagus committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    1133dba View commit details
    Browse the repository at this point in the history

  2. Inline a couple of isRef/isDict checks in the ObjectLoader code 

    As we've seen in numerous other cases, avoiding unnecessary function calls is never a bad thing (even if the effect is probably tiny here).
    @Snuffleupagus
    Snuffleupagus committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    2d35a49 View commit details
    Browse the repository at this point in the history