Convert globalScope and isNodeJS to proper modules
#11316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
commented
Nov 10, 2019
Slightly unrelated to the rest of the patch, but this also removes an out-of-place `globals` definition from the `web/viewer.js` file.
Given that this shouldn't change after the `pdf.js`/`pdf.worker.js` files have been loaded, it doesn't seems necessary to keep this as a function.
Snuffleupagus
force-pushed
the
globalScope-isNodeJS-modules
branch
from
c219282
to
74e00ed
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1d8f9e1b94e766b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/bbb4f2159360d81/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/bbb4f2159360d81/output.txt Total script time: 18.53 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/1d8f9e1b94e766b/output.txt Total script time: 26.38 mins
Image differences available at: http://54.215.176.217:8877/1d8f9e1b94e766b/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Nov 10, 2019
|
Looks better like this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly unrelated to the rest of the patch, but this also removes an out-of-place
globalsdefinition from theweb/viewer.jsfile.