Replace done callbacks in the font-tests with async/await instead
#13263
Conversation
Snuffleupagus
force-pushed
the
font-tests-rm-done
branch
from
ceac40e
to
3d55b2b
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/afd6c5bb5eebbe4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/ffaa042170ad00d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/afd6c5bb5eebbe4/output.txt Total script time: 1.85 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/ffaa042170ad00d/output.txt Total script time: 3.68 mins
|
From: Bot.io (Linux m4)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/609f1301a11d9e0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/efd7cf73f3383fc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/609f1301a11d9e0/output.txt Total script time: 1.87 mins
|
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/efd7cf73f3383fc/output.txt Total script time: 60.00 mins |
From: Bot.io (Linux m4)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9a0566b9abfbb0d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/13130e486ba9f41/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9a0566b9abfbb0d/output.txt Total script time: 1.84 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/13130e486ba9f41/output.txt Total script time: 5.13 mins
|
By replacing `XMLHttpRequest` with a `fetch` call, the helper function can be modernized to use async/await instead. Note that the headers doesn't seem necessary to set now, since: - The Fetch API provides a method for accessing the response as *text*, which renders the "Content-type" header unnecessary. - According to https://developer.mozilla.org/en-US/docs/Glossary/Forbidden_header_name, the "Content-length" header isn't necessary.
Snuffleupagus
force-pushed
the
font-tests-rm-done
branch
from
9a7f095
to
7b8d249
Compare
|
/botio fonttest |
From: Bot.io (Linux m4)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/cc1f24a218c3eff/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/5966d5239d525f2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/cc1f24a218c3eff/output.txt Total script time: 1.85 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/5966d5239d525f2/output.txt Total script time: 3.56 mins
|
From: Bot.io (Linux m4)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9cacc3cfdd926a1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/8fb67353b43ef5c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9cacc3cfdd926a1/output.txt Total script time: 1.83 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/8fb67353b43ef5c/output.txt Total script time: 4.70 mins
|
|
Looks really good, and using the fetch API is also much cleaner. Thank you for doing this! |
No description provided.