Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace done callbacks in the font-tests with async/await instead #13263

Merged
merged 2 commits into from
Apr 21, 2021

Commits on Apr 19, 2021

  1. Configuration menu
    Copy the full SHA
    3d55b2b View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Convert the font-test ttx helper function to use the Fetch API

    By replacing `XMLHttpRequest` with a `fetch` call, the helper function can be modernized to use async/await instead.
    Note that the headers doesn't seem necessary to set now, since:
     - The Fetch API provides a method for accessing the response as *text*, which renders the "Content-type" header unnecessary.
     - According to https://developer.mozilla.org/en-US/docs/Glossary/Forbidden_header_name, the "Content-length" header isn't necessary.
    Snuffleupagus committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    7b8d249 View commit details
    Browse the repository at this point in the history