For mozcentral use Firefox color theme instead of system theme. #13314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
approved these changes
Apr 28, 2021
web/app.js
Outdated
Comment on lines
427
to
430
| let mediaMatcher = "prefers-color-scheme"; | ||
| if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) { | ||
| mediaMatcher = "-moz-toolbar-prefers-color-scheme"; | ||
| } |
There was a problem hiding this comment.
Nit: I'd suggest just setting the value directly, rather than first defining it and then immediately overwriting it here:
const mediaMatcher =
typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")
? "-moz-toolbar-prefers-color-scheme"
: "prefers-color-scheme";
brendandahl
force-pushed
the
color-theme
branch
from
ed39883
to
2c713f9
Compare
Snuffleupagus
added a commit
that referenced
this pull request
Oct 17, 2021
…e." since -moz-toolbar-prefers-color-scheme was removed Reverts #13314, see https://groups.google.com/g/firefox-dev/c/vajhbYKDpPM Given that `-moz-toolbar-prefers-color-scheme` was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1736038, unless we fix this before the next PDF.js update in mozilla-central we'll thus break dark mode in the Firefox built-in PDF Viewer.
bh213
pushed a commit
to bh213/pdf.js
that referenced
this pull request
Jun 3, 2022
…e." since -moz-toolbar-prefers-color-scheme was removed Reverts mozilla#13314, see https://groups.google.com/g/firefox-dev/c/vajhbYKDpPM Given that `-moz-toolbar-prefers-color-scheme` was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1736038, unless we fix this before the next PDF.js update in mozilla-central we'll thus break dark mode in the Firefox built-in PDF Viewer.
rousek
pushed a commit
to signosoft/pdf.js
that referenced
this pull request
Aug 10, 2022
…e." since -moz-toolbar-prefers-color-scheme was removed Reverts mozilla#13314, see https://groups.google.com/g/firefox-dev/c/vajhbYKDpPM Given that `-moz-toolbar-prefers-color-scheme` was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1736038, unless we fix this before the next PDF.js update in mozilla-central we'll thus break dark mode in the Firefox built-in PDF Viewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1701691