Revert "For mozcentral use Firefox color theme instead of system theme." since -moz-toolbar-prefers-color-scheme was removed
#14155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e." since -moz-toolbar-prefers-color-scheme was removed Reverts #13314, see https://groups.google.com/g/firefox-dev/c/vajhbYKDpPM Given that `-moz-toolbar-prefers-color-scheme` was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1736038, unless we fix this before the next PDF.js update in mozilla-central we'll thus break dark mode in the Firefox built-in PDF Viewer.
Snuffleupagus
force-pushed
the
revert-13314-color-theme
branch
from
8254ae4
to
aae8a21
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/aa9acdf0350ac00/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/aa9acdf0350ac00/output.txt Total script time: 4.52 mins Published |
Snuffleupagus
requested review from
brendandahl,
calixteman and
timvandermeij
|
This obviously only needs one reviewer, but I'm nonetheless tagging a couple of potential reviewers to make sure that this lands as soon as possible; please note #14155 (comment). |
timvandermeij
approved these changes
Oct 19, 2021
|
Looks good; thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13314, see https://groups.google.com/g/firefox-dev/c/vajhbYKDpPM
Given that
-moz-toolbar-prefers-color-schemewas removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1736038, unless we fix this before the next PDF.js update in mozilla-central we'll thus break dark mode in the Firefox built-in PDF Viewer.