Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the no-var rule in the src/core/evaluator.js file #13344

Merged
merged 2 commits into from May 7, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

The only slight complication here were some of the switch-cases, in getOperatorList/getTextContent, where the parsing is done asynchronously.
However, those cases are easy to deal with by wrapping the code within its own block; please see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/switch#block-scope_variables_within_switch_statements

These changes were made automatically, using `gulp lint --fix`.
…tically, in the `src/core/evaluator.js` file

The only *slight* complication here were some of the `switch`-cases, in `getOperatorList`/`getTextContent`, where the parsing is done asynchronously.
However, those cases are easy to deal with by wrapping the code within its own block; please see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/switch#block-scope_variables_within_switch_statements
@Snuffleupagus
Copy link
Collaborator Author

This wasn't as difficult as I previously thought, probably thanks to more experience than last time I looked at this :-)
(With this PR, and my pending one for the image-decoders, I think that I'm done with no-var enabling for now.)

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 6, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a90256270cae395/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 6, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/b2920778fb746b7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 6, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/a90256270cae395/output.txt

Total script time: 25.93 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/a90256270cae395/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented May 6, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/b2920778fb746b7/output.txt

Total script time: 29.69 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/b2920778fb746b7/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit a3632c0 into mozilla:master May 7, 2021
@timvandermeij
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants