Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the no-var rule in the src/core/evaluator.js file #13344

Merged
merged 2 commits into from
May 7, 2021
Merged

Enable the no-var rule in the src/core/evaluator.js file #13344

merged 2 commits into from
May 7, 2021

Commits on May 6, 2021

  1. Enable the no-var rule in the src/core/evaluator.js file 

    These changes were made automatically, using `gulp lint --fix`.
    @Snuffleupagus
    Snuffleupagus committed May 6, 2021
    Configuration menu
    Copy the full SHA
    f93c3b9 View commit details
    Browse the repository at this point in the history

  2. Fix the remaining no-var failures, which couldn't be handled automa… 

    …tically, in the `src/core/evaluator.js` file

The only *slight* complication here were some of the `switch`-cases, in `getOperatorList`/`getTextContent`, where the parsing is done asynchronously.
However, those cases are easy to deal with by wrapping the code within its own block; please see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/switch#block-scope_variables_within_switch_statements
    @Snuffleupagus
    Snuffleupagus committed May 6, 2021
    Configuration menu
    Copy the full SHA
    0ef9b5a View commit details
    Browse the repository at this point in the history