XFA - Get each page asynchronously in order to avoid blocking the event loop (#14014) #14240

calixteman · 2021-11-05T19:53:42Z

No description provided.

calixteman · 2021-11-05T19:54:15Z

/botio test

pdfjsbot · 2021-11-05T19:54:17Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b68c5085de5fbc1/output.txt

pdfjsbot · 2021-11-05T19:54:17Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/83a3803c9eddf5b/output.txt

pdfjsbot · 2021-11-05T20:17:41Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b68c5085de5fbc1/output.txt

Total script time: 23.39 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/b68c5085de5fbc1/reftest-analyzer.html#web=eq.log

src/core/document.js

pdfjsbot · 2021-11-05T20:36:21Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/83a3803c9eddf5b/output.txt

Total script time: 42.06 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/83a3803c9eddf5b/reftest-analyzer.html#web=eq.log

calixteman · 2021-11-05T20:36:56Z

/botio test

pdfjsbot · 2021-11-05T20:36:57Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/572d1cfaf0a9ad1/output.txt

pdfjsbot · 2021-11-05T20:36:57Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a681e07e52d9602/output.txt

pdfjsbot · 2021-11-05T21:00:24Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/572d1cfaf0a9ad1/output.txt

Total script time: 23.44 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 8
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/572d1cfaf0a9ad1/reftest-analyzer.html#web=eq.log

calixteman · 2021-11-05T21:09:59Z

/botio test

pdfjsbot · 2021-11-05T21:10:01Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7d078fffdb96651/output.txt

pdfjsbot · 2021-11-05T21:10:01Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/3bdccd61c321b9b/output.txt

pdfjsbot · 2021-11-05T21:19:28Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a681e07e52d9602/output.txt

Total script time: 42.50 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 10
  different first/second rendering: 3

Image differences available at: http://54.193.163.58:8877/a681e07e52d9602/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-11-05T21:33:25Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7d078fffdb96651/output.txt

Total script time: 23.39 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 11
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/7d078fffdb96651/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-11-05T22:01:46Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3bdccd61c321b9b/output.txt

Total script time: 42.30 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 7
  different first/second rendering: 2

Image differences available at: http://54.193.163.58:8877/3bdccd61c321b9b/reftest-analyzer.html#web=eq.log

calixteman · 2021-11-05T22:19:35Z

/botio test

pdfjsbot · 2021-11-05T22:19:36Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6cd4acebfc282ef/output.txt

pdfjsbot · 2021-11-05T22:19:36Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/58ab654140f7234/output.txt

pdfjsbot · 2021-11-05T22:43:03Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6cd4acebfc282ef/output.txt

Total script time: 23.44 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 13

Image differences available at: http://54.241.84.105:8877/6cd4acebfc282ef/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-11-05T23:26:37Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/58ab654140f7234/output.txt

Total script time: 42.31 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/58ab654140f7234/reftest-analyzer.html#web=eq.log

src/core/xfa/factory.js

…nt loop (mozilla#14014)

calixteman · 2021-11-06T12:25:50Z

/botio test

pdfjsbot · 2021-11-06T12:25:51Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/578aa1fa3a92cc8/output.txt

pdfjsbot · 2021-11-06T12:25:51Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/90ea0838a20f7fb/output.txt

pdfjsbot · 2021-11-06T13:14:47Z

From: Bot.io (Windows)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dd96d9ce7a8c80c/output.txt

calixteman · 2021-11-06T13:14:56Z

No more test failures for the moment.
I don't know if it'll fix the test issues but it likely doesn't hurt to have this patch.
Once everything is ok, we can merge it and see for its positive effects on CI in the next days.
/botio test

pdfjsbot · 2021-11-06T13:14:57Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/8058b754d05b6d5/output.txt

pdfjsbot · 2021-11-06T13:14:57Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/7be1e71d2e23feb/output.txt

pdfjsbot · 2021-11-06T13:24:23Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7fd0fbce8a4e2a7/output.txt

Total script time: 9.60 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/7fd0fbce8a4e2a7/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-11-06T13:31:42Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/dd96d9ce7a8c80c/output.txt

Total script time: 16.91 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/dd96d9ce7a8c80c/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-11-06T13:47:35Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/8058b754d05b6d5/output.txt

Total script time: 23.20 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 8
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/8058b754d05b6d5/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-11-06T14:13:05Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7be1e71d2e23feb/output.txt

Total script time: 41.38 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/7be1e71d2e23feb/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2021-11-06T14:22:20Z

/botio xfatest

pdfjsbot · 2021-11-06T14:22:22Z

From: Bot.io (Linux m4)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dd34e1232833a22/output.txt

pdfjsbot · 2021-11-06T14:22:22Z

From: Bot.io (Windows)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/54f950ac9a3f78b/output.txt

pdfjsbot · 2021-11-06T14:31:59Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/dd34e1232833a22/output.txt

Total script time: 9.61 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/dd34e1232833a22/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-11-06T14:39:08Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/54f950ac9a3f78b/output.txt

Total script time: 16.76 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/54f950ac9a3f78b/reftest-analyzer.html#web=eq.log

calixteman · 2021-11-06T15:02:57Z

/botio xfatest

pdfjsbot · 2021-11-06T15:02:58Z

From: Bot.io (Linux m4)

Received

Command cmd_xfatest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/577041f18bc97ca/output.txt

pdfjsbot · 2021-11-06T15:02:58Z

From: Bot.io (Windows)

Received

Command cmd_xfatest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e8ceb30a045a090/output.txt

pdfjsbot · 2021-11-06T15:12:37Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/577041f18bc97ca/output.txt

Total script time: 9.64 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/577041f18bc97ca/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-11-06T15:19:36Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e8ceb30a045a090/output.txt

Total script time: 16.63 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/e8ceb30a045a090/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2021-11-06T19:45:17Z

/botio xfatest

pdfjsbot · 2021-11-06T19:45:18Z

From: Bot.io (Linux m4)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fad8536f863dcd6/output.txt

pdfjsbot · 2021-11-06T19:45:18Z

From: Bot.io (Windows)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0854729e8482adf/output.txt

pdfjsbot · 2021-11-06T19:54:58Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/fad8536f863dcd6/output.txt

Total script time: 9.65 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/fad8536f863dcd6/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-11-06T20:01:51Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/0854729e8482adf/output.txt

Total script time: 16.53 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/0854729e8482adf/reftest-analyzer.html#web=eq.log

Snuffleupagus

It certainly seems like this have helped, since there's not been any intermittent failures so far.
This only leaves one thing, trying to explain why exactly this actually worked :-)

r=me, since this doesn't really effect anything except the XFA-code now; thank you!

calixteman · 2021-11-06T20:22:35Z

I really hope those intermittents are fixed: crossed fingers...

marco-c · 2021-11-07T00:45:42Z

\o/

calixteman requested review from brendandahl and Snuffleupagus November 5, 2021 19:53

Snuffleupagus requested changes Nov 5, 2021

View reviewed changes

src/core/document.js Outdated Show resolved Hide resolved

calixteman force-pushed the 14014 branch from 7619547 to 82e410e Compare November 5, 2021 21:09

Snuffleupagus reviewed Nov 6, 2021

View reviewed changes

src/core/xfa/factory.js Outdated Show resolved Hide resolved

XFA - Get each page asynchronously in order to avoid blocking the eve…

1681e25

…nt loop (mozilla#14014)

calixteman force-pushed the 14014 branch from 82e410e to 1681e25 Compare November 6, 2021 12:25

Snuffleupagus approved these changes Nov 6, 2021

View reviewed changes

Snuffleupagus linked an issue Nov 6, 2021 that may be closed by this pull request

Intermittent bug with XFA test on the bots #14014

Closed

calixteman merged commit efb4455 into mozilla:master Nov 6, 2021

calixteman deleted the 14014 branch November 6, 2021 20:21

timvandermeij removed the request for review from brendandahl November 7, 2021 13:16

XFA - Get each page asynchronously in order to avoid blocking the event loop (#14014) #14240

XFA - Get each page asynchronously in order to avoid blocking the event loop (#14014) #14240

Conversation

calixteman commented Nov 5, 2021

calixteman commented Nov 5, 2021

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Failed

calixteman commented Nov 5, 2021

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

calixteman commented Nov 5, 2021

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Failed

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Failed

calixteman commented Nov 5, 2021

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Failed

calixteman commented Nov 6, 2021

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Received

calixteman commented Nov 6, 2021

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Failed

pdfjsbot commented Nov 6, 2021