Use the *built* components/pdf_viewer.css file in the reference tests
#15101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we're loading the `web/annotation_layer_builder.css` and `web/xfa_layer_builder.css` files *directly* during the reference tests. This becomes a problem is we want to reduce duplication in the CSS-files, e.g. by placing *common* rules in the `web/pdf_viewer.css` file. Given that `gulp components` is already being utilized when running tests, we can thus use that to instead depend on the *entire* viewer-components CSS-file in the reference tests.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1f4b433ef97773f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8462b9010627adc/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/8462b9010627adc/output.txt Total script time: 26.37 mins
Image differences available at: http://54.241.84.105:8877/8462b9010627adc/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1f4b433ef97773f/output.txt Total script time: 28.87 mins
|
timvandermeij
approved these changes
Jun 25, 2022
|
Looks good; thanks for preventing any issues here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're loading the
web/annotation_layer_builder.cssandweb/xfa_layer_builder.cssfiles directly during the reference tests.This becomes a problem is we want to reduce duplication in the CSS-files, e.g. by placing common rules in the
web/pdf_viewer.cssfile.Given that
gulp componentsis already being utilized when running tests, we can thus use that to instead depend on the entire viewer-components CSS-file in the reference tests.