Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-major] Enable editing by default #15339

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

Note that this patch at least shouldn't land until both bug 1784272 and bug 1785248 are fixed.

@Snuffleupagus Snuffleupagus force-pushed the enable-editor branch 6 times, most recently from 89977ca to bc0bfcf Compare August 27, 2022 13:38
@Snuffleupagus Snuffleupagus force-pushed the enable-editor branch 2 times, most recently from bde9506 to cde89be Compare September 3, 2022 11:39
@mozilla mozilla deleted a comment from pdfjsbot Sep 3, 2022
@mozilla mozilla deleted a comment from pdfjsbot Sep 3, 2022
@mozilla mozilla deleted a comment from pdfjsbot Sep 3, 2022
@mozilla mozilla deleted a comment from pdfjsbot Sep 3, 2022
@Snuffleupagus Snuffleupagus force-pushed the enable-editor branch 3 times, most recently from 6e0264b to d83eca8 Compare September 10, 2022 12:04
Note that this patch *at least* shouldn't land until both [bug 1784272](https://bugzilla.mozilla.org/show_bug.cgi?id=1784272) and [bug 1785248](https://bugzilla.mozilla.org/show_bug.cgi?id=1785248) are fixed.
@mozilla mozilla deleted a comment from pdfjsbot Sep 13, 2022
@mozilla mozilla deleted a comment from pdfjsbot Sep 13, 2022
@mozilla mozilla deleted a comment from pdfjsbot Sep 13, 2022
@mozilla mozilla deleted a comment from pdfjsbot Sep 13, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/65438d7270e4fa3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/333cb57322c87f9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/65438d7270e4fa3/output.txt

Total script time: 4.95 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/333cb57322c87f9/output.txt

Total script time: 9.05 mins

  • Integration Tests: FAILED

@Snuffleupagus Snuffleupagus marked this pull request as ready for review September 13, 2022 09:00
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/08eace5671f544c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/08eace5671f544c/output.txt

Total script time: 2.17 mins

Published

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Snuffleupagus Snuffleupagus merged commit 5e5aa9f into mozilla:master Sep 13, 2022
@Snuffleupagus Snuffleupagus deleted the enable-editor branch September 13, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants