[Editing] Disable the HandTool during editing (bug 1792422) #15522
Conversation
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c8769ea1cd470b0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c8769ea1cd470b0/output.txt Total script time: 2.16 mins Published |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/be8536a00fa68eb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/86c26046acc12e9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/be8536a00fa68eb/output.txt Total script time: 5.05 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/86c26046acc12e9/output.txt Total script time: 9.36 mins
|
This extends the approach used in PresentationMode to also cover the AnnotationEditor, and tries to handle the combination of both cases correctly. In order to simplify the overall implementation we simply track the *first* seen "previous" cursorTool, and don't allow it to be reset as long as either PresentationMode or an AnnotationEditor is being used.
Snuffleupagus
force-pushed
the
editor-disable-cursor-tools
branch
from
fe700e5
to
205ab95
Compare
|
Slightly tweaked the code, replacing /botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ad86b20eab6bf9f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fcde0da4aeab14e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ad86b20eab6bf9f/output.txt Total script time: 5.07 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/fcde0da4aeab14e/output.txt Total script time: 10.76 mins
|
This extends the approach used in PresentationMode to also cover the AnnotationEditor, and tries to handle the combination of both cases correctly. In order to simplify the overall implementation we simply track the first seen "previous" cursorTool, and don't allow it to be reset as long as either PresentationMode or an AnnotationEditor is being used.