Change the PDFViewerApplication.open method to only accept objects
#15972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2d83cf37fc0d8c7/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/be505d39c006094/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/be505d39c006094/output.txt Total script time: 4.88 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2d83cf37fc0d8c7/output.txt Total script time: 17.01 mins
|
Snuffleupagus
force-pushed
the
PDFViewerApplication-open-signature
branch
3 times, most recently
from
37cb647
to
6129be7
Compare
If this method was added today, I really can't imagine that we'd support anything *except* objects. Unfortunately we cannot just remove this now, since the code has existed since "forever", however we can deprecate this and limit it to only the GENERIC build. Furthermore, we can avoid a redundant `PDFViewerApplication.setTitleUsingUrl` call in the Firefox PDF Viewer since the title has already been set previously in that case.
timvandermeij
approved these changes
Jan 28, 2023
|
Thank you for doing this! |
The-Compiler
added a commit
to qutebrowser/qutebrowser
that referenced
this pull request
Mar 14, 2023
A quick tour through the PDF.js API: v1.0.1040 introduced the ability to pass an object to PDFView.open() instead of passing an URL: mozilla/pdf.js#5254 v1.6.210 (?) renamed PDFView to PDFViewerApplication: ffa276a v3.3.122 made it mandatory to pass an object (and also made originalURL optional when doing so): mozilla/pdf.js#15972 We should probably properly get rid of old version support at some point (see #7619), but until then, I *think* this approach should work with older versions still. Fixes #7618
The-Compiler
added a commit
to qutebrowser/qutebrowser
that referenced
this pull request
Mar 14, 2023
A quick tour through the PDF.js API: v1.0.1040 introduced the ability to pass an object to PDFView.open() instead of passing an URL: mozilla/pdf.js#5254 v1.6.210 (?) renamed PDFView to PDFViewerApplication: ffa276a v3.3.122 made it mandatory to pass an object (and also made originalURL optional when doing so): mozilla/pdf.js#15972 We should probably properly get rid of old version support at some point (see #7619), but until then, I *think* this approach should work with older versions still. Fixes #7618 (cherry picked from commit 924a7a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this method was added today, I really can't imagine that we'd support anything except objects. Unfortunately we cannot just remove this now, since the code has existed since "forever", however we can deprecate this and limit it to only the GENERIC build.
Furthermore, we can avoid a redundant
PDFViewerApplication.setTitleUsingUrlcall in the Firefox PDF Viewer since the title has already been set previously in that case.