Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the LoopbackPort class to use a Set internally #16030

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

This is a tiny bit more compact, thanks to the Set.prototype.delete method.

This is a tiny bit more compact, thanks to the `Set.prototype.delete` method.
@Snuffleupagus
Copy link
Collaborator Author

/botio xfatest

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Linux m4)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/00ff1e4bc4cf8c4/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Windows)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/90dad4bac2f03ec/output.txt

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/00ff1e4bc4cf8c4/output.txt

Total script time: 10.13 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 3

Image differences available at: http://54.241.84.105:8877/00ff1e4bc4cf8c4/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/90dad4bac2f03ec/output.txt

Total script time: 16.07 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/90dad4bac2f03ec/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit a49d1d1 into mozilla:master Feb 9, 2023
@Snuffleupagus Snuffleupagus deleted the LoopbackPort-Set branch February 9, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants