Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the unicorn/prefer-negative-index ESLint plugin rule #16185

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Enable the unicorn/prefer-negative-index ESLint plugin rule #16185

merged 1 commit into from
Mar 24, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/51df994c4728d35/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/253382feefcac92/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/51df994c4728d35/output.txt

Total script time: 26.46 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 7
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/51df994c4728d35/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/253382feefcac92/output.txt

Total script time: 32.31 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 29

Image differences available at: http://54.193.163.58:8877/253382feefcac92/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/33d142d2fe1a381/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5babd3aaf228e6e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/33d142d2fe1a381/output.txt

Total script time: 1.18 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/5babd3aaf228e6e/output.txt

Total script time: 7.60 mins

  • Lint: Passed

calixteman
calixteman approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Snuffleupagus Snuffleupagus merged commit c706c6c into mozilla:master Mar 24, 2023
@Snuffleupagus Snuffleupagus deleted the prefer-negative-index branch March 24, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @pdfjsbot @calixteman