[api-minor] Update the minimum supported Google Chrome version #16249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch changes the minimum supported version of Google Chrome as follows: - Chrome 88, which was released on 2021-01-19; see https://en.wikipedia.org/wiki/Google_Chrome_version_history This is done to allow use of modern CSS features, such as e.g. `:is()` and `:where()` in the code-base.
timvandermeij
approved these changes
Apr 10, 2023
|
Looks good to me! |
|
Sadly, this means that PDF.js 3.5.141 is the last to work with QtWebEngine 5.15 LTS and hence with the latest versions of Falkon, Angelfish, etc., even in legacy mode. (QtWebEngine 5.15 LTS is based on Chromium 87 and still receives security fixes.) 3.6 partially works but looks very broken (the grayed out accessibility text is visible and the icons are not displayed), 3.8 with its further minimum version bump to Chromium 92 is completely broken (blank rendering with 0 pages, due to JavaScript errors) in QtWebEngine 5.15 LTS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch changes the minimum supported version of Google Chrome as follows:
This is done to allow use of modern CSS features, such as e.g.
:is()and:where()in the code-base.