Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly clip the text in the text layer (fixes #16316) #16318

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman linked an issue Apr 18, 2023 that may be closed by this pull request
src/core/evaluator.js Fixed Show fixed Hide fixed
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CodeQL warning looks correct, so please fix that.

r=me, with passing tests; thank you!

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/229909e108b77be/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/08c9c136cb18bc6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/08c9c136cb18bc6/output.txt

Total script time: 27.03 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 13
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/08c9c136cb18bc6/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/229909e108b77be/output.txt

Total script time: 33.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 32
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/229909e108b77be/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 3e292dc into mozilla:master Apr 18, 2023
@calixteman calixteman deleted the issue16316 branch April 18, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chars aren't correctly clipped in the text layer
3 participants