Simplify the fontID handling in PartialEvaluator.loadFont
#16437
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3ed12c7a3a76927/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/bda480465a502c9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/bda480465a502c9/output.txt Total script time: 27.22 mins
Image differences available at: http://54.241.84.105:8877/bda480465a502c9/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3ed12c7a3a76927/output.txt Total script time: 34.69 mins
Image differences available at: http://54.193.163.58:8877/3ed12c7a3a76927/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Looks good to me, but I'll leave the final review for @calixteman due to more familiarity with this particular code.
The `fontID` handling is quite old and predates the use of the `idFactory` to generate a unique id for each font, hence we can simplify this code a little bit.
Snuffleupagus
force-pushed
the
loadFont-simpler-fontID
branch
from
44f211e
to
4355e76
Compare
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4e787ca9e4b1899/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f230ab9e659f773/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f230ab9e659f773/output.txt Total script time: 3.92 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4e787ca9e4b1899/output.txt Total script time: 22.74 mins
Image differences available at: http://54.241.84.105:8877/4e787ca9e4b1899/reftest-analyzer.html#web=eq.log |
The
fontIDhandling is quite old and predates the use of theidFactoryto generate a unique id for each font, hence we can simplify this code a little bit.