Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Slightly postpone the move in the DOM in order to not block the UI (bug 1854991) #17031

Merged
merged 1 commit into from Sep 25, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman added this to In progress in PDF.js editing via automation Sep 25, 2023
@Snuffleupagus
Copy link
Collaborator

Given the timeout, is it technically possible that the editor has been removed before we try to move it in the DOM?
If so, do we handle that situation gracefully without any errors?

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing integration tests; thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0a67faf635b5fa9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e01bab3a2659f69/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/e01bab3a2659f69/output.txt

Total script time: 5.37 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/0a67faf635b5fa9/output.txt

Total script time: 24.98 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 549c414 into mozilla:master Sep 25, 2023
3 checks passed
PDF.js editing automation moved this from In progress to Done Sep 25, 2023
@calixteman calixteman deleted the bug1854991 branch September 25, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants