-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly re-factor how the viewer initializes debug-only functionality #18061
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a7d3fa144c4d0e7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a7d3fa144c4d0e7/output.txt Total script time: 1.15 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/68ea8845b0e5829/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/68ea8845b0e5829/output.txt Total script time: 27.54 mins
Image differences available at: http://54.241.84.105:8877/68ea8845b0e5829/reftest-analyzer.html#web=eq.log |
This avoids having to add a couple of event listeners in the viewer, when debugging is enabled, and is consistent with the existing handling of `FontInspector` and `StepperManager` in the API.
…p.js` Given that this is a debug-only, and fairly short, function we can just inline the code.
…arams` Given that this is a debug-only function we don't need to define it "globally" in the `web/app.js` file.
1eccf31
to
5fbc5ba
Compare
Looks good! |
Please refer to the individual commit messages for additional information.