-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the TextLayerRenderTask
implementation
#18089
Conversation
- Change all possible semi-private methods into properly private ones. Note that this code is old enough to predate standard classes. - Move the `appendText` helper function into `TextLayerRenderTask`, as a private method, to avoid having to manually pass in the scope. - Simplify `#layoutText` by directly passing in all necessary data. This is possible after the changes PR 18052.
Please note: Ideally I'd like to re-factor this code even further, making it a bit more similiar to the |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2e4e5deca1f1360/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 2 Live output at: http://54.193.163.58:8877/ffd54c01a307935/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/2e4e5deca1f1360/output.txt Total script time: 27.40 mins
Image differences available at: http://54.241.84.105:8877/2e4e5deca1f1360/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ffd54c01a307935/output.txt Total script time: 40.03 mins
Image differences available at: http://54.193.163.58:8877/ffd54c01a307935/reftest-analyzer.html#web=eq.log |
Looks good to me; thanks! |
Change all possible semi-private methods into properly private ones. Note that this code is old enough to predate standard classes.
Move the
appendText
helper function intoTextLayerRenderTask
, as a private method, to avoid having to manually pass in the scope.Simplify
#layoutText
by directly passing in all necessary data. This is possible after the changes PR Restore broken functionality and simplify the implementation insrc/display/text_layer.js
#18052.