Introduce a getRect utility function for the integration tests
#18154
Conversation
Over time the number of integration tests that get the rectangle for a given selector has increased quite a bit, and the code to do so has consequently become duplicated. This commit refactors the integration tests to move the rectangle fetching code to a single place, which reduces the code by over 400 lines and makes the individual tests simpler.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7e3b9ce876464b4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/47ff448a9ca9340/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/47ff448a9ca9340/output.txt Total script time: 6.77 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7e3b9ce876464b4/output.txt Total script time: 7.44 mins
|
|
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f14d32944d75320/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f14d32944d75320/output.txt Total script time: 19.96 mins
|
Over time the number of integration tests that get the rectangle for a given selector has increased quite a bit, and the code to do so has consequently become duplicated.
This commit refactors the integration tests to move the rectangle fetching code to a single place, which reduces the code by over 400 lines and makes the individual tests simpler.