Initialize all user-options upfront in AppOptions #18501
Conversation
- Initialize all user-options upfront, to allow getting the options without having to check if they exist first. (This is easier to implement after PR 18475 landed.) - Move the user-options into a private field in `AppOptions`. (This code is old enough to pre-date general availability of that class feature.) - Move code/methods limited to GENERIC-builds into `AppOptions`.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fac32c04df34930/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/61237ad1436b104/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/61237ad1436b104/output.txt Total script time: 18.86 mins
|
|
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c925caff6941e41/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c925caff6941e41/output.txt Total script time: 8.71 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/edbc4370d2912ae/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/edbc4370d2912ae/output.txt Total script time: 1.03 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0a9d0b1d2913894/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0cfb3a2c3688c11/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0cfb3a2c3688c11/output.txt Total script time: 29.45 mins
Image differences available at: http://54.241.84.105:8877/0cfb3a2c3688c11/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0a9d0b1d2913894/output.txt Total script time: 47.33 mins
Image differences available at: http://54.193.163.58:8877/0a9d0b1d2913894/reftest-analyzer.html#web=eq.log |
|
Thank you for improving this! |
Initialize all user-options upfront, to allow getting the options without having to check if they exist first. (This is easier to implement after PR Remove the unused
AppOptions.removemethod #18475 landed.)Move the user-options into a private field in
AppOptions. (This code is old enough to pre-date general availability of that class feature.)Move code/methods limited to GENERIC-builds into
AppOptions.