-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that the progressCallback is defined before calling it #3368
Conversation
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/aa17acc4609e030/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/aa17acc4609e030/output.txt Total script time: 0.20 mins Published |
Avoid triggering plugin list initialization on startup (Bugzilla 881575)
total: data.total | ||
}); | ||
}, this); | ||
if(this.progressCallback) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep handler in place even when progressCallback is undefined. Could you move `if (this.progressCallback) {' inside transportDocProgress function. Don't forget a space after 'if'
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/c58c4939d140b37/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/c58c4939d140b37/output.txt Total script time: 0.33 mins Published |
Extract text-selection, search and match logic from viewer.js
Resolved by ce218d0 |
Fix issue #3367
When calling getDocument without a progressCallback we get an error when trying to call it.