Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the progressCallback is defined before calling it #3368

Closed
wants to merge 9 commits into from
Closed

Check that the progressCallback is defined before calling it #3368

wants to merge 9 commits into from

Conversation

benbro
Copy link
Contributor

@benbro benbro commented Jun 15, 2013

Fix issue #3367

When calling getDocument without a progressCallback we get an error when trying to call it.

@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/aa17acc4609e030/output.txt

@pdfjsbot
Copy link

Avoid triggering plugin list initialization on startup (Bugzilla 881575)
total: data.total
});
}, this);
if(this.progressCallback) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep handler in place even when progressCallback is undefined. Could you move `if (this.progressCallback) {' inside transportDocProgress function. Don't forget a space after 'if'

@yurydelendik
Copy link
Contributor

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c58c4939d140b37/output.txt

@pdfjsbot
Copy link

@yurydelendik
Copy link
Contributor

Resolved by ce218d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants