-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert UTF8 encoded passwords to ISO-8859-1 for |R = 6| encryption (issue 6010) #6016
Conversation
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2da7da4f606ab0d/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2da7da4f606ab0d/output.txt Total script time: 0.83 mins Published |
"rounds": 1, | ||
"link": false, | ||
"type": "load", | ||
"password": "æøå", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can \uXXXX
or \xHH
notation be used here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems to work just fine, thank you!
…issue 6010) For passwords where the encoding already is correct, the conversion is a no-op. Also, since `encodeURIComponent` might throw, we need to make sure that we handle that case too. Fixes 6010.
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ef3d2156bd22aa4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/45c1deb4a4273d3/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/45c1deb4a4273d3/output.txt Total script time: 18.02 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/ef3d2156bd22aa4/output.txt Total script time: 22.97 mins
|
According to https://docs.google.com/spreadsheets/d/1Bg3eSe5cGSZJy-4k4j2KV_3hS0uhNtx6Xz3OV3JcncA/edit?pli=1#gid=0, this could also be useful for |
The only viewer that does that is PDF Viewer in Chrome. The Adobe Reader does not do conversion for revision = 4. |
Fair enough. Otherwise that can be done later if there are concrete issues for that. Thanks. |
Convert UTF8 encoded passwords to ISO-8859-1 for |R = 6| encryption (issue 6010)
Thank you for the fix. |
For passwords where the encoding already is correct, the conversion is a no-op.
Also, since
encodeURIComponent
might throw, we need to make sure that we handle that case too.Fixes #6010.