Change test-case issue4914 to an annotations test
#6787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PDF file (see issue 4914) originally regressed in PR 4318, and was subsequently fixed in PR 4915. I added the PDF file as a (linked) test-case in PR 6481, in an effort to prevent regressions. Since we at that time didn't have the necessary framework in place, in order to correctly test annotations, this almost regressed *again* in PR #6672 (comment). In that PDF file, some of the annotations are both printable and hidden, and should definitely *not* be visible on normal display. Hence this patch, which adds the `annotations` flag to the manifest in order to ensure that those annotations won't be rendered when `intent === 'display'`.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8e82a089253f6c3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/237a52ac47a741b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/237a52ac47a741b/output.txt Total script time: 20.26 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/8e82a089253f6c3/output.txt Total script time: 20.75 mins
|
timvandermeij
added a commit
that referenced
this pull request
Dec 21, 2015
Change test-case `issue4914` to an `annotations` test
|
Good point, thanks for addressing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PDF file (see issue #4914) originally regressed in PR #4318, and was subsequently fixed in PR #4915.
I added the PDF file as a (linked) test-case in PR #6481, in an effort to prevent regressions. Since we at that time didn't have the necessary framework in place, in order to correctly test annotations, this almost regressed again in PR #6672 (comment).
In that PDF file, some of the annotations are both printable and hidden, and should definitely not be visible on normal display. Hence this patch, which adds the
annotationsflag to the manifest in order to ensure that those annotations won't be rendered whenintent === 'display'.@timvandermeij Would you mind reviewing this?