Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change test-case issue4914 to an annotations test #6787

Merged
merged 1 commit into from
Dec 21, 2015
Merged

Change test-case issue4914 to an annotations test #6787

merged 1 commit into from
Dec 21, 2015

Commits on Dec 21, 2015

  1. Change test-case issue4914 to an annotations test 

    This PDF file (see issue 4914) originally regressed in PR 4318, and was subsequently fixed in PR 4915.

I added the PDF file as a (linked) test-case in PR 6481, in an effort to prevent regressions. Since we at that time didn't have the necessary framework in place, in order to correctly test annotations, this almost regressed *again* in PR #6672 (comment).

In that PDF file, some of the annotations are both printable and hidden, and should definitely *not* be visible on normal display. Hence this patch, which adds the `annotations` flag to the manifest in order to ensure that those annotations won't be rendered when `intent === 'display'`.
    @Snuffleupagus
    Snuffleupagus committed Dec 21, 2015
    Configuration menu
    Copy the full SHA
    ae4ec2e View commit details
    Browse the repository at this point in the history