Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the baseTransform is applied when rendering annotations #6814

Merged
merged 1 commit into from Dec 28, 2015
Merged

Ensure that the baseTransform is applied when rendering annotations #6814

merged 1 commit into from Dec 28, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #3350.
Fixes #5946.
Fixes #6334.
Fixes #6722.
Probably fixes #3826 (since the PDF files are no longer available, I cannot confirm it).

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/78b1b875ee58dc4/output.txt

@timvandermeij
Copy link
Contributor

I made a reduced test case that you can use for this patch:
issue5946-reduced.pdf

@timvandermeij
Copy link
Contributor

Complete list of issues fixed by this PR: #5946, #3826, #6334, #6722 and #3350.

Fixes 3350.
Fixes 5946.
Fixes 6334.
Fixes 6722.
Probably fixes 3826 (since the PDF files are no longer available, I cannot confirm it).
@Snuffleupagus
Copy link
Collaborator Author

@timvandermeij Thank you for the reduced test-case; and also for finding the other issues!

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9bc2a974b447a8f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/b198d68663d600a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/9bc2a974b447a8f/output.txt

Total script time: 20.28 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/b198d68663d600a/output.txt

Total script time: 20.78 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/545854240d2855e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5dd894102f52725/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/5dd894102f52725/output.txt

Total script time: 20.14 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/545854240d2855e/output.txt

Total script time: 20.32 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

timvandermeij added a commit that referenced this pull request Dec 28, 2015
…sform

Ensure that the `baseTransform` is applied when rendering annotations
@timvandermeij timvandermeij merged commit edf8ccc into mozilla:master Dec 28, 2015
@timvandermeij
Copy link
Contributor

Thank you!

@Rob--W
Copy link
Member

Rob--W commented Dec 28, 2015

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants