Allow local PDF files to be viewed in local frames #6941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good after these comments have been addressed. I have confirmed that this patch works using the provided steps. |
The Chrome extension enforces that local files cannot be embedded in non-local web pages. The previous check was too strict (because the origin of a file:-URL is "null"), and prevented local PDF from being viewed in local files). This patch fixes that problem, by querying the actual tab URL via the background page. Steps to verify: 1. Create a HTML file: `<iframe src=test.pdf width=100% height=100%>` 2. Build and load the extension. 3. Allow file access to the extension at `chrome://extensions` 4. Open the HTML file from a file:// URL. 5. VERIFY: The extension should attempt to load the PDF file. 6. Now open the following (replace ID with the extension ID, which you can find at `chrome://extensions`): `data:text/html,<iframe src="chrome-extension://ID/file:///test.pdf">` 7. VERIFY: The next error should be displayed: "Refused to load a local file in a non-local page for security reasons."
Rob--W
force-pushed
the
crx-allow-pdf-in-local-frames
branch
from
096e571
to
0ec82d4
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://107.21.233.14:8877/019435c15af83bd/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/019435c15af83bd/output.txt Total script time: 0.81 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Feb 10, 2016
Allow local PDF files to be viewed in local frames
|
Verified, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chrome extension enforces that local files cannot be embedded in non-local web pages. The previous check was too strict (because the origin of a file:-URL is "null"), and prevented local PDF from being viewed in local files).
This bug was reported by a user in the Chrome Web Store:
This patch fixes that problem, by querying the actual tab URL via the background page.
Steps to verify:
<iframe src=test.pdf width=100% height=100%>chrome://extensionscan find at
chrome://extensions):data:text/html,<iframe src="chrome-extension://ID/file:///test.pdf">"Refused to load a local file in a non-local page for security reasons."