Adding "proper" message port for fake worker. #6948
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/de62240b704a243/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a05182b8e7101a5/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/de62240b704a243/output.txt Total script time: 19.97 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a05182b8e7101a5/output.txt Total script time: 21.20 mins
|
yurydelendik
force-pushed
the
fake-cloning
branch
from
366caa2
to
3dd63c3
Compare
yurydelendik
force-pushed
the
fake-cloning
branch
from
3dd63c3
to
6e729d4
Compare
|
with disableWorker=true commit /botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/12d505682696963/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a1a561551fa0c06/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/a1a561551fa0c06/output.txt Total script time: 18.35 mins
Image differences available at: http://107.21.233.14:8877/a1a561551fa0c06/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/12d505682696963/output.txt Total script time: 20.11 mins
|
yurydelendik
force-pushed
the
fake-cloning
branch
from
6e729d4
to
27a4826
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/9be9fbac8135ede/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e1c36b03ac058be/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/9be9fbac8135ede/output.txt Total script time: 20.32 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e1c36b03ac058be/output.txt Total script time: 21.33 mins
|
| return; | ||
| } | ||
|
|
||
| var clonned = new WeakMap(); |
There was a problem hiding this comment.
Spelling nit: shouldn't this be cloned instead (here, and elsewhere in the patch)?
| clonned.set(value, result); | ||
| return result; | ||
| } | ||
| result = Array.isArray(value) ? [] : {}; |
There was a problem hiding this comment.
Why not just use isArray from shared/util.js?
|
This pull request needs to be rebased, the comments above need to be addressed and the polyfill can be removed as it is already committed on |
|
Since it seems that @yurydelendik has been quite busy with other things lately, here's this patch rebased to master and with the nits addressed (but please note that I've not run any tests with it locally): |
Attempt to properly fix fake worker port. See also #6938.