Adding "proper" message port for fake worker. #7624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that we don't test with workers disabled (which is a good thing, given how long that'd probably take), I'm not sure how much value there is in running the tests but let's do it for good measure anyway. /botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ac3e7fcd5c333b4/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/4a7409ffc2fdb44/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/ac3e7fcd5c333b4/output.txt Total script time: 24.47 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/4a7409ffc2fdb44/output.txt Total script time: 39.97 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the patch from PR #6948, rebased to master, with review nits addressed, and obviously maintaining the correct author information.
Attempt to properly fix fake worker port. See also #6938.
Edit: Supersedes, hence fixes #6948.