Remove/deprecate specifying a pageNumber directly after the hash symbol (#), to improve compatibility since other PDF viewers don't support this form (issue 7746) #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
| } else { // Named (or explicit) destination. | ||
| if ((typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) && | ||
| (isPageNumber(hash) && hash < this.pagesCount)) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
D'oh! You're obviously correct, don't know how I managed to make that kind of mistake in such a small patch. Good eye, thanks :-)
…ol (#), to improve compatibility since other PDF viewers don't support this form (issue 7746)
There's no mention of our `#{pagenum}` form in http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/pdf_open_parameters.pdf, and Adobe Reader doesn't seem to support it either.
Hence this patch removes support for it in the extensions, but keeps it in the `GENERIC` build with a deprecation warning and a fallback to handle it as a destination.
Fixes 7746.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6a4dc89bc19e789/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6a4dc89bc19e789/output.txt Total script time: 2.73 mins Published |
|
Nice work! |
Snuffleupagus
deleted the
setHash-remove-pageNumber-directly-after-hash
branch
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…eNumber-directly-after-hash Remove/deprecate specifying a pageNumber directly after the hash symbol (#), to improve compatibility since other PDF viewers don't support this form (issue 7746)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no mention of our
#{pagenum}form in http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/pdf_open_parameters.pdf, and Adobe Reader doesn't seem to support it either.Hence this patch removes support for it in the extensions, but keeps it in the
GENERICbuild with a deprecation warning and a fallback to handle it as a destination.Fixes #7746.