Adjust the brace-style ESLint rule to disallow single lines (and also enable no-iterator)
#8025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so enable `no-iterator`) See http://eslint.org/docs/rules/brace-style. Having the opening/closing braces on the same line can often make the code slightly more difficult to read, in particular for `if`/`else if` statements, compared to using new lines. This patch also, for consistency with `mozilla-central`, enables the [`no-iterator`](http://eslint.org/docs/rules/no-iterator) rule. Note that this rule didn't require a single code change.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/74fd5c95ee4d463/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/74fd5c95ee4d463/output.txt Total script time: 2.25 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b1ae5b381a5cf91/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/cc782133ae7dd9d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/cc782133ae7dd9d/output.txt Total script time: 22.26 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b1ae5b381a5cf91/output.txt Total script time: 26.24 mins
|
timvandermeij
approved these changes
Feb 4, 2017
|
Nice work! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…_allowSingleLine_false Adjust the `brace-style` ESLint rule to disallow single lines (and also enable `no-iterator`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://eslint.org/docs/rules/brace-style.
Having the opening/closing braces on the same line can often make the code slightly more difficult to read, in particular for
if/else ifstatements, compared to using new lines.This patch also, for consistency with
mozilla-central, enables theno-iteratorrule. Note that this rule didn't require a single code change.