-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the brace-style
ESLint rule to disallow single lines (and also enable no-iterator
)
#8025
Adjust the brace-style
ESLint rule to disallow single lines (and also enable no-iterator
)
#8025
Conversation
…so enable `no-iterator`) See http://eslint.org/docs/rules/brace-style. Having the opening/closing braces on the same line can often make the code slightly more difficult to read, in particular for `if`/`else if` statements, compared to using new lines. This patch also, for consistency with `mozilla-central`, enables the [`no-iterator`](http://eslint.org/docs/rules/no-iterator) rule. Note that this rule didn't require a single code change.
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/74fd5c95ee4d463/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/74fd5c95ee4d463/output.txt Total script time: 2.25 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b1ae5b381a5cf91/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/cc782133ae7dd9d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/cc782133ae7dd9d/output.txt Total script time: 22.26 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b1ae5b381a5cf91/output.txt Total script time: 26.24 mins
|
Nice work! |
…_allowSingleLine_false Adjust the `brace-style` ESLint rule to disallow single lines (and also enable `no-iterator`)
See http://eslint.org/docs/rules/brace-style.
Having the opening/closing braces on the same line can often make the code slightly more difficult to read, in particular for
if
/else if
statements, compared to using new lines.This patch also, for consistency with
mozilla-central
, enables theno-iterator
rule. Note that this rule didn't require a single code change.