Fix two cmap related issues. #8747
Conversation
In issue mozilla#8707, there's a char code mapped to a non- existing glyph which shouldn't be drawn. However, we saw it was missing and tried to then use the post table and end up mapping it incorrectly. This illuminated a problem with issue mozilla#5704 and bug 893730 where glyphs disappeared after above fix. This was from the cmap returning the wrong glyph id. Which in turn was caused because the font had multiple of the same type of cmap table and we were choosing the last one. Now, we instead default to the first one. I'm unsure if we should instead be merging the multiple cmaps, but using only the first one works.
|
Fixes #8707 |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2cf6570045efc72/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/385d6434fe2c885/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/2cf6570045efc72/output.txt Total script time: 16.65 mins
Image differences available at: http://54.67.70.0:8877/2cf6570045efc72/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/385d6434fe2c885/output.txt Total script time: 29.33 mins
|
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fbc4ee6154cc406/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.215.176.217:8877/5d727f6dfb20000/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/fbc4ee6154cc406/output.txt Total script time: 16.62 mins
Image differences available at: http://54.67.70.0:8877/fbc4ee6154cc406/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/5d727f6dfb20000/output.txt Total script time: 29.18 mins
|
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d2926a7feabd552/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/7b673f1c712a3dd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d2926a7feabd552/output.txt Total script time: 15.55 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/7b673f1c712a3dd/output.txt Total script time: 27.29 mins
|
|
This didn't solve my problem: Spaces are rendered as glyphs (big dots) |
|
@mikelweb please file a new issue with your pdf. |
Fix two cmap related issues.
In issue #8707, there's a char code mapped to a non-
existing glyph which shouldn't be drawn. However, we
saw it was missing and tried to then use the post table and
end up mapping it incorrectly.
This illuminated a problem with issue #5704 and bug
893730 where glyphs disappeared after above fix. This was
from the cmap returning the wrong glyph id. Which in turn was
caused because the font had multiple of the same type of cmap
table and we were choosing the last one. Now, we instead
default to the first one. I'm unsure if we should instead be
merging the multiple cmaps, but using only the first one works.
Fixes #8707