Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ø (LATIN CAPITAL LETTER O WITH STROKE) doesn't appear #5704

Closed
mikemorr opened this issue Feb 6, 2015 · 1 comment · Fixed by #5651
Closed

Ø (LATIN CAPITAL LETTER O WITH STROKE) doesn't appear #5704

mikemorr opened this issue Feb 6, 2015 · 1 comment · Fixed by #5651
Labels
font-conversion font-truetype regression
Milestone
2015 Q1

Comments

@mikemorr
Copy link

mikemorr commented Feb 6, 2015

In this PDF: http://www.jazzbooks.com/mm5/download/FREE-nomenclature.pdf
the character Ø (U+00D8, LATIN CAPITAL LETTER O WITH STROKE) doesn't appear. Issue occurs on both Windows and Mac. Screenshots from http://mozilla.github.io/pdf.js/web/viewer.html and Adobe Reader:
pdfjs
adobereader
@mikemorr mikemorr mentioned this issue Feb 6, 2015
Closed
@Snuffleupagus
Copy link
Collaborator

This is a regression from PR #4259.

Edit: Reduced test-case https://www.dropbox.com/s/p4f328hwd0bus2b/issue5704_reduced.pdf?dl=0.

@Snuffleupagus Snuffleupagus added this to the 2015 Q1 milestone Feb 6, 2015
@Snuffleupagus Snuffleupagus mentioned this issue Feb 7, 2015
Merged
brendandahl added a commit to brendandahl/pdf.js that referenced this issue Aug 4, 2017
@brendandahl
Fix two cmap related issues.
0bef50d 
In issue mozilla#8707, there's a char code mapped to a non-
existing glyph which shouldn't be drawn. However, we
saw it was missing and tried to then use the post table and
end up mapping it incorrectly.

This illuminated a problem with issue mozilla#5704 and bug
893730 where glyphs disappeared after above fix.  This was
from the cmap returning the wrong glyph id. Which in turn was
caused because the font had multiple of the same type of cmap
table and we were choosing the last one. Now, we instead
default to the first one. I'm unsure if we should instead be
merging the multiple cmaps, but using only the first one works.
@brendandahl brendandahl mentioned this issue Aug 4, 2017
Merged
movsb pushed a commit to movsb/pdf.js that referenced this issue Jul 14, 2018
@brendandahl
Fix two cmap related issues.
4bebf7b 
In issue mozilla#8707, there's a char code mapped to a non-
existing glyph which shouldn't be drawn. However, we
saw it was missing and tried to then use the post table and
end up mapping it incorrectly.

This illuminated a problem with issue mozilla#5704 and bug
893730 where glyphs disappeared after above fix.  This was
from the cmap returning the wrong glyph id. Which in turn was
caused because the font had multiple of the same type of cmap
table and we were choosing the last one. Now, we instead
default to the first one. I'm unsure if we should instead be
merging the multiple cmaps, but using only the first one works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
font-conversion font-truetype regression
Projects
None yet
Milestone
2015 Q1
Development

Successfully merging a pull request may close this issue.

Try to skip mapping of missing TrueType and CIDFontType2 glyphs
2 participants
@mikemorr @Snuffleupagus