-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add button to redirect to results page #129
add button to redirect to results page #129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 325 346 +21
Branches 35 41 +6
=========================================
+ Hits 325 346 +21
Continue to review full report at Codecov.
|
e461c37
to
5c2794a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good--thanks!
Hey @eng-esther ! Can you please clean up the commit log? currently it contains the message in your former latest commit, so it doesn't reflect the content of this patch. Also I see there are a lot of conflicting files, it would be good to rebase the patch before we can review. Most of them are snaphot files so these ones should be as easy as running the test runner with Thanks! |
5c2794a
to
1859ee0
Compare
46f120e
to
0ad3484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
0ad3484
to
eb4309b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
remove absolute
Need to discuss with team first before moving the button above the search input field