Use good keys when rendering arrays of components #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ciliation algorithm works better
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## beta #675 +/- ##
=======================================
Coverage 91.41% 91.41%
=======================================
Files 69 69
Lines 1620 1620
Branches 291 291
=======================================
Hits 1481 1481
Misses 111 111
Partials 28 28 ☔ View full report in Codecov by Sentry. |
julienw
added a commit
to julienw/perfcompare
that referenced
this pull request
Jun 13, 2024
…ad of the index so that React's reconciliation algorithm works better
julienw
added a commit
to julienw/perfcompare
that referenced
this pull request
Jun 13, 2024
… have the same platform for the same test
beatrice-acasandrei
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I make sure that all rows and group of rows have unique keys that don't change. Previously we were using the index. This should make React's reconciliation algorithm faster when doing operations such as filtering. See https://legacy.reactjs.org/docs/reconciliation.html for more information about this algorithm.
I profiled locally when filtering out and in a platform, and this seems a bit faster than previously.
I'm requesting review from Beatrice because she should know whether my assumptions are correct.