Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

accountdb cookie is a session cookie, should have expiry set. #204

Closed
jrgm opened this issue Apr 25, 2013 · 2 comments
Closed

accountdb cookie is a session cookie, should have expiry set. #204

jrgm opened this issue Apr 25, 2013 · 2 comments

Comments

@jrgm
Copy link
Contributor

jrgm commented Apr 25, 2013

This should probably have an expiration equal to the expiration embedded in the client-sessions cookie.

Set-Cookie: accountdb=kljfaoiueowiur...jofiasudfou; path=/; secure; httponly

@ozten
Copy link
Contributor

ozten commented Apr 25, 2013

Interesting. This bug applies to both our session and accountdb cookies.

It probably hasn't been a problem in production for session, since we reset the cookie as soon as possible.

Great catch!

ozten added a commit that referenced this issue Apr 25, 2013
@ozten ozten closed this as completed in 0863b32 Apr 25, 2013
@jrgm
Copy link
Contributor Author

jrgm commented Apr 26, 2013

Cookies are now returned on the appropriate requests with 'expires' set to match the expiry embedded in the cookie.

Set-Cookie: session=FBT...cJb4.1367009493164.86400000.w7D...w64; path=/; expires=Sat, 27 Apr 2013 20:51:33 GMT; secure; httponly
Set-Cookie: accountdb=_j9...ENA.1367009671298.31536000000.G2s...wpg; path=/; expires=Sat, 26 Apr 2014 20:54:31 GMT; secure; httponly

ozten added a commit that referenced this issue May 15, 2013
ozten added a commit that referenced this issue May 29, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants