This repository has been archived by the owner on May 10, 2019. It is now read-only.
update database code and mysql driver to handle stalled connections #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* all database functions return an err as the first param which is non-null for failure. * all wsapis handle database errors and return service unavailable to client. * stalled-mysql-test implements unit tests to verify proper failure behavior of all wsapis. * configuration parameter added to define max allowed time per query
ghost
assigned 
|
this is a beast. because of its size it would be better to merge sooner than later (minimize conflicts, maximize time on dev before going out in this weeks train) when merged, it will close issue #990 |
|
r+ with one suggested consideration. Tests passed for me and using app worked. If no furhter changes, please land on dev branch, or if feedback causes a significant change, happy to review another commit on this pull request. |
|
looks good (didn't run tests, trusting @ozten). r+ from me in case you wanted more reviews for such a large commit. |
…ebug console output, fail slow queries rather than retrying, and add a statsd counter for failed_query
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.