i18n fixes #2039
i18n fixes #2039
Conversation
…ing substition from .json files, and debug locale
…d and sent to translators
| @@ -61,7 +61,7 @@ app.use(i18n.abide({ | |||
| supported_languages: config.get('supported_languages'), | |||
| default_lang: config.get('default_lang'), | |||
| debug_lang: config.get('debug_lang'), | |||
| locale_directory: config.get('locale_directory'), | |||
| translation_directory: config.get('translation_directory'), | |||
There was a problem hiding this comment.
Minor nitpick:
locale was chosen to maintain consistency with the Playdoh framework. The benefit is that a Mozilla community member who has been hacking on webdev projects can more easily jump into the Identity stack.
There was a problem hiding this comment.
I have no qualms naming the config param locale. I only made this change because we no longer use the locale/ directory in our software (where the .pos and .mos live).
What's your preference?
There was a problem hiding this comment.
Just a knit with a reason. Roll whichever way.
|
unit tests failing according to Travis. (travis' fault? I didn't run tests locally) r+ once tests pass. |
|
I'll merge pending a happy travis! |
This change refines the way we debug our i18n implementation and does the following:
it-CH) and it always works - issue enable debug 'locale' in our dev env #1970 and issue it-ch/db-LB not working on ephemeral deployments when defined in aws.json #2006