This repository has been archived by the owner on May 10, 2019. It is now read-only.
Disable tests that cause weird errors, sometimes. #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4114 (kinda). If any one of the commented tests is enabled, the QUnit tests start failing intermittantly in all versions of IE, but no other browsers. It seems like stale state is somehow hanging around, but it's not consistent, and it doesn't follow any particular pattern. E.g., it's just as easy to get a pass-pass-fail set of runs as it is to get fail-fail-pass. Since we previously had *no* QUnit tests for navigator.id.watch, and given that it's intermittant, I'm leaning toward this being something strange with the test suite, rather than a new error. I suggest disabling these specific test cases for now, and rigorously manually testing IE before going to production.
|
STUPID CAN |
seanmonstar
added a commit
that referenced
this pull request
Apr 3, 2014
Disable tests that cause weird errors, sometimes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4114 (kinda).
If any one of the commented tests is enabled, the QUnit tests start failing
intermittantly in all versions of IE, but no other browsers. It seems like
stale state is somehow hanging around, but it's not consistent, and it doesn't
follow any particular pattern.
E.g., it's just as easy to get a pass-pass-fail set of runs as it is to get
fail-fail-pass.
Since we previously had no QUnit tests for navigator.id.watch, and given that
it's intermittant, I'm leaning toward this being something strange with the test
suite, rather than a new error.
I suggest disabling these specific test cases for now, and rigorously manually
testing IE before going to production.