Skip to content
This repository has been archived by the owner on Jan 8, 2019. It is now read-only.

Provide a sample localization #40

Merged
merged 3 commits into from Jun 12, 2011
Merged

Provide a sample localization #40

merged 3 commits into from Jun 12, 2011

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Jun 7, 2011

Playdoh comes with the examples app which is localization-ready, but it takes a long series of unnecessarily complicated steps to actually see anything in any other language than English. This might be discouraging, and amplifies the feeling that l10n is something that happens somewhere else. I'd like to change it.

I suggest that Playdoh come by default with the locale directory, with a sample localization of the examples app. I chose to localize into French, since it's popular/easily recognized/similar to English enough to not look as if something just broke (Polish, anyone...?) :)

I made some changes to the docs to better reflect the l10n process that we've actually followed on a few past projects in Q1 and Q2.

Let me know what you think. Happy to discuss this further!

@fwenzel
Copy link
Member

fwenzel commented Jun 9, 2011

This looks very, very good. I am happy to include an example locale like you suggested. I agree L10n shouldn't look like it's not core to the project.

Can you git rebase -i this and squash some of these commits, so you end up with a shorter list? Tweaks and original commit do not need to be separate.

@stasm
Copy link
Contributor Author

stasm commented Jun 9, 2011

I squashed the commits into 4 big ones:

  • actual changes to locale/ and bin/update_site.py
  • changes to settings.py
  • changes to the documentation
  • tests.

@fwenzel
Copy link
Member

fwenzel commented Jun 10, 2011

Argh. Can you rebase it? This request can't be automatically merged anymore, probably because I messed with the docs. The docs themselves are now in the separate playdoh-docs repository (so that users don't fork the playdoh docs when starting off their project).

Sorry for the added work :(

@fwenzel
Copy link
Member

fwenzel commented Jun 10, 2011

Other than that, r+!

@stasm
Copy link
Contributor Author

stasm commented Jun 10, 2011

Argh. Can you rebase it? This request can't be automatically merged anymore, probably because I messed with the docs. The docs themselves are now in the separate playdoh-docs repository (so that users don't fork the playdoh docs when starting off their project).

Sure. Should I submit a new pull req to playdoh-docs with the updated l10n.rst file then?

Sorry for the added work :(

No problem at all!

@fwenzel
Copy link
Member

fwenzel commented Jun 10, 2011

Yes, a pull request to playdoh-docs works -- or you can land your code directly. Do you have push rights to the repo(s)?

@stasm
Copy link
Contributor Author

stasm commented Jun 10, 2011

I'll land in playdoh-docs once this request is merged, so that I can reference the merge commit.

@fwenzel
Copy link
Member

fwenzel commented Jun 12, 2011

Woot!

fwenzel added a commit that referenced this pull request Jun 12, 2011
Provide a sample localization
@fwenzel fwenzel merged commit 87abd66 into mozilla:base Jun 12, 2011
stasm added a commit to mozilla/playdoh-docs that referenced this pull request Jun 13, 2011
@stasm
Copy link
Contributor Author

stasm commented Jun 13, 2011

Woot indeed! :) Thanks Fred.

I landed the docs in mozilla/playdoh-docs/@256a89a

willkg added a commit that referenced this pull request Aug 13, 2013
91561d9 Update to Django 1.4.6  r=r1cky
198b178 Merge pull request #42 from dpoirier/update-tower
e8e6095 Update tower
77d2cc7 Merge pull request #36 from jsocol/arecibo
54be25a Merge pull request #40 from peterbe/upgrade-django-session-csrf
963f25c upgrade django-session-csrf for safer keys
d5db036 Drop django-arecibo.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants