Fix bug 1632206: Preserve whitespace in submitted translations (#1668)

Add custom validation, which does not strip whitespace from the translation field.
mozilla · Aug 6, 2020 · b91218b · b91218b
1 parent 11f2ea0
commit b91218b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/pontoon/translations/forms.py b/pontoon/translations/forms.py
@@ -54,3 +54,6 @@ def clean_plural_form(self):
         if self.cleaned_data["plural_form"] == "-1":
             return None
         return self.cleaned_data["plural_form"]
+
+    def clean_translation(self):
+        return self.data.get("translation", "")
diff --git a/pontoon/translations/tests/test_forms.py b/pontoon/translations/tests/test_forms.py
@@ -107,3 +107,18 @@ def test_create_translation_form_clean_paths(entity_a, locale_a):
     )
     assert form.is_valid()
     assert form.cleaned_data["paths"] == ["a/d.ext", "foo/bar"]
+
+
+@pytest.mark.django_db
+def test_create_translation_form_clean_translation(entity_a, locale_a):
+    form = CreateTranslationForm(
+        {
+            "entity": entity_a.pk,
+            "translation": " salut ",
+            "locale": locale_a.code,
+            "plural_form": "-1",
+            "original": "hello",
+        }
+    )
+    assert form.is_valid()
+    assert form.cleaned_data["translation"] == " salut "