Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set direction on placeables #2267

Closed
bugzilla-to-github opened this issue Feb 12, 2021 · 2 comments · Fixed by #2353
Closed

Set direction on placeables #2267

bugzilla-to-github opened this issue Feb 12, 2021 · 2 comments · Fixed by #2353
Assignees
@nick-zanetti
Labels
bug P3 Default, possibly shipping in the following two quarters

Comments

@bugzilla-to-github
Copy link
Collaborator

bugzilla-to-github commented Feb 12, 2021 •
edited by mathjazz
Loading

This issue was created automatically by a script.

Bug 1692620

Bug Reporter: @mathjazz

Created attachment 9202997
Screenshot

Everywhere we mark up placeables (i.e. everywhere we show strings in the translate view except in the textarea), we need to set the dir attribute to ltr in order to prevent bad display of placeables in RTL strings (as seen on the screenshot).
@nick-zanetti
Copy link
Contributor

Could I have this assigned to me?

@mathjazz
Copy link
Collaborator

Done :)

nick-zanetti added a commit to nick-zanetti/pontoon that referenced this issue Nov 2, 2021
@nick-zanetti
Fix mozilla#2267 Set dir attribute on placeables
3ead6ec 
Set the dir attribute to ltr for placeable instances in parsers folder.
This prevents bad display of placeables in RTL strings.
nick-zanetti added a commit to nick-zanetti/pontoon that referenced this issue Nov 2, 2021
@nick-zanetti
Fix mozilla#2267 Set dir attribute on placeables
55489f0 
Set the dir attribute to ltr for placeable instances in parsers folder.
This prevents bad display of placeables in RTL strings.
@nick-zanetti nick-zanetti mentioned this issue Nov 2, 2021
Merged
mathjazz pushed a commit that referenced this issue Nov 3, 2021
@nick-zanetti
Fix #2267 Set dir attribute on placeables (#2353)
7f94b2e 
Set the dir attribute to ltr for placeable instances in parsers folder.
This prevents bad display of placeables in RTL strings.
@mathjazz mathjazz mentioned this issue Nov 6, 2021
Closed
nick-zanetti added a commit to nick-zanetti/pontoon that referenced this issue Nov 23, 2021
@nick-zanetti
Fix mozilla#2267 Set dir attribute on placeables
a3d9447 
Set the dir attribute to ltr for placeable instances in parsers folder.
This prevents bad display of placeables in RTL strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nick-zanetti nick-zanetti

Labels
bug P3 Default, possibly shipping in the following two quarters
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2267 Set dir attribute on placeables nick-zanetti/pontoon
3 participants
@mathjazz @nick-zanetti @bugzilla-to-github