Fix bug 1524602 - Hide Editor actions and settings when user is logged out. #1205
Conversation
|
So, this doesn't work yet, because the text In the DOM I see this: <p class="banner">
<a href="/accounts/fxa/login/?scope=profile%3Auid+profile%3Aemail+profile%3Adisplay_name"></a>
Sign in to translate.
</p>I'm at a complete loss there... @stasm, please, help. |
|
It's solved thanks for @stasm! |
|
It's reserved and it's not allowed to have any content. It's content model is defined to be empty. So |
| editor-editor-button-copy = Copy | ||
| editor-editor-button-clear = Clear | ||
| editor-editor-button-save = Save | ||
| editor-editor-button-suggest = Suggest |
There was a problem hiding this comment.
editor-editor looks weird... Is that because you're simply following the $module-$component convention?
There was a problem hiding this comment.
Yeah, I don't like it much either. At some point we should have a conversation about those IDs, and decide on a clear rule.
There was a problem hiding this comment.
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1528926 to kick off the conversation about the id naming scheme.
| <Localized | ||
| id="editor-editor-sign-in-to-translate" | ||
| a={ | ||
| <a href='/accounts/fxa/login/?scope=profile%3Auid+profile%3Aemail+profile%3Adisplay_name'></a> |
There was a problem hiding this comment.
This is breaking tests:
./src/modules/editor/components/Editor.js
Line 86: Anchors must have content and the content must be accessible by a screen reader jsx-a11y/anchor-has-content
No description provided.