Some noImplicitAny TS fixes #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pike
commented
Dec 12, 2021
| params: NavigationParams, | ||
| ): Entity | null | undefined { | ||
| ): Entity | undefined { |
There was a problem hiding this comment.
I wonder what kinda state we're in if this doesn't have an Entity?
There's a bunch of code in the frontend that assumes this exists.
There was a problem hiding this comment.
A very bad state. I think it's unreachable unless the state or the store get horribly corrupted somehow.
Really this might be taken as a sign that we should deeply refactor the state handling to reflect this. Not sure if it's worth the trouble, though.
eemeli
approved these changes
Dec 13, 2021
| >, | ||
| history: ReturnType<typeof historySelector>, | ||
| entity: ReturnType<typeof entities.selectors.getSelectedEntity>, | ||
| ) { |
There was a problem hiding this comment.
Is the return type intentionally dropped here?
There was a problem hiding this comment.
Yes, TS is good about deducing it. And leaving out null and undefined should help when we transition to strictNull
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly about fixing selectors to work on the
RootState.This reduces the TS errors for
--noImplicitAny, but increases--strictNullChecks. The culprit there isgetSelectedEntity, which used to beanyand isEntity | undefinednow.I wonder what state we're in when that's undefined.
I also made things just
undefinedinstead ofnull | undefined