Revert "Add new glean-server library to define pings for server-side Glean" #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Glean" This reverts commit 0a68e4d.
akkomar
requested review from
chutten,
whd,
mikaeld,
Dexterp37,
badboy and
travis79
as code owners
badboy
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #717 which broke
mozilla_schema_generatortask.It turns out that before, when dependency list was empty, schema generator pulled
glean-coreas a default dependency. This added internal Glean metrics toaccounts-eventsschema. Now when we addglean-serverdependency these metrics are not added to the schema and generator fails at validation stage.